Skip to content

Conversation

@gazayas
Copy link
Contributor

@gazayas gazayas commented Nov 10, 2023

Continuation of #1108.

There were no issues with tests thankfully due to #990 and #1007.
Only one problem where I had to make sure the Signed out successfully flash notice showed up properly.

@jagthedrummer
Copy link
Contributor

I'm thinking we should do a larger version bump on this one since it'll change the behavior of apps if people don't notice the change and undo it for themselves.

@jagthedrummer
Copy link
Contributor

Or... maybe it should be a config option that lives as turned off in the starter repo but that we turn on via bin/setup? I thought we were doing that for some config option or another but I'm not finding it right off the bat.

@gazayas
Copy link
Contributor Author

gazayas commented Nov 15, 2023

I thought we were doing that for some config option or another but I'm not finding it right off the bat.

Yeah, I don't THINK we have a config in place, but I'm impartial as to having one or not. I know there are developers who have their marketing site somewhere else, so I can whip up an implementation in bin/configure if that's ideal. Otherwise it's currently not clear that developers can edit this setting manually when setting up a new app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants